Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Correctly describe default value of autodocs #23560

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

cgatian
Copy link
Contributor

@cgatian cgatian commented Jul 21, 2023

What I did

Updates the autodoc documentation to refer to the proper default value, "tag"

How to test

Docs only change, should be straightforward.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

@jonniebigodes jonniebigodes self-assigned this Jul 21, 2023
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jul 21, 2023
@jonniebigodes
Copy link
Contributor

@cgatian, we appreciate you taking the time to put together this pull request and helping us improve the documentation. That was a great find. Thank you very much 🙏 !

All is good on my end. I'll merge it once the checklist clears.

Have a fantastic weekend.

Stay safe

@jonniebigodes jonniebigodes merged commit c06e18a into storybookjs:next Jul 21, 2023
1 check passed
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
Update autodoc to proper default value

(cherry picked from commit c06e18a)
@cgatian
Copy link
Contributor Author

cgatian commented Jul 22, 2023

@jonniebigodes
Thanks for putting a smile on my face. I really appreciate the positive attitude and quick attention to the PR. It gave me a positive feeling to future contributions. Great job.

@jonniebigodes
Copy link
Contributor

@cgatian, no need to thank whatsoever. It was my pleasure. And appreciate the kind words !🙇

Looking forward to your next contribution.

storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
Update autodoc to proper default value

(cherry picked from commit c06e18a)
storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
Update autodoc to proper default value

(cherry picked from commit c06e18a)
@JReinhold JReinhold changed the title Update autodoc to proper default value Docs: Correctly describe default value of autodocs Jul 24, 2023
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 24, 2023
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
30 tasks
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal documentation patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants