-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Fix initialization of Storybook in Angular 16.1 #23598
Merged
valentinpalkovic
merged 1 commit into
next
from
valentin/fix-initialization-of-storybook-in-angular-16.1
Jul 25, 2023
Merged
Angular: Fix initialization of Storybook in Angular 16.1 #23598
valentinpalkovic
merged 1 commit into
next
from
valentin/fix-initialization-of-storybook-in-angular-16.1
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
angular
patch:yes
Bugfix & documentation PR that need to be picked to main branch
ci:normal
labels
Jul 25, 2023
valentinpalkovic
force-pushed
the
valentin/fix-initialization-of-storybook-in-angular-16.1
branch
from
July 25, 2023 10:38
06e3194
to
48694d1
Compare
valentinpalkovic
changed the title
Fix initialization of Storybook in Angular 16.1
Angular: Fix initialization of Storybook in Angular 16.1
Jul 25, 2023
yannbf
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me! I guess nx.json will always be present in Nx projects.
cc @mandarini
valentinpalkovic
deleted the
valentin/fix-initialization-of-storybook-in-angular-16.1
branch
July 25, 2023 12:09
27 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
Closed
33 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
30 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
…n-of-storybook-in-angular-16.1 Angular: Fix initialization of Storybook in Angular 16.1 (cherry picked from commit 0aec101)
kasperpeulen
removed
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23568
What I did
Fixed initialization of Storybook in Angular 16.1. An nx project was wrongly recognized, because
@angular-eslint/schematics
introduced a dependency onnx
. I have removed the logic to identify a workspace being a nx workspace by evaluatingnx
as a dependency. Instead, we only rely on the existent of anx.json
file, since that should be enough to identify a workspace using nx or not in most of the cases.How to test
Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>