Indexers: Mark indexers
as experimental
#23676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #23457
Telescopes on top of #23660
What I did
Changed the preset property from
indexers
toexperimental_indexers
. They are stillindexers
internally everywhere, only thepreset.apply
calls andStorybookConfig
type changed so if users were to add their own indexers, they'd need to add them asexperimental_indexers
inmain.ts
.I didn't change all the new types that the indexers use, that didn't seem necessary. I also didn't add a console warning given that we're adding default indexers which would trigger this warning every time.
I also reverted my updates to the code snippets, as I think they should get updated when we write the new docs at the end of this project, and not before that.
How to test
main.ts
file:Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>