-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Add contributing note for disabling actions in forks #23801
Conversation
Ok, failing on Danger JS 😳 - I made the docs changes in the GH site. I'll pull down the PR locally and have a look in a bit. |
Am getting errors running |
Ok, the failing CI on this PR is unrelated to my local issues so setting back to review. |
1bd4afc
to
b08e357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these improvements, @johnhunter!
I left some suggested further improvements for you to integrate, then we can merge.
559bd4f
to
24d0358
Compare
Co-authored-by: Kyle Gach <kyle.gach@gmail.com>
24d0358
to
79170a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thanks again, @johnhunter.
What I did
How to test
Documentation only.
If required you can confirm contributing guide link does not 404.
Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>