-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add an experimental API for adding sidebar top toolbar #23811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
JReinhold,
cdedreuille,
tmeasday,
kasperpeulen and
valentinpalkovic
as code owners
August 11, 2023 15:33
…ar-top-slot # Conflicts: # code/lib/manager-api/src/lib/addons.ts # code/lib/manager-api/src/modules/addons.ts # code/lib/types/src/modules/addons.ts
tmeasday
changed the title
UI: Add an experimental API for adding sidebar bottom toolbar
UI: Add an experimental API for adding sidebar top toolbar
Aug 12, 2023
yannbf
reviewed
Aug 21, 2023
yannbf
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yannbf I think I addressed all your (very valid) concerns/findings. |
yannbf
approved these changes
Aug 22, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoped off: #23778
What I did
I added a new type of addon that will be injected into a new top bar of the sidebar.
It looks like this:
Notice the "accessibility" icon besides the regular gear icon
How to test
Here's how to add something to the ui storybook:
code/ui/.storybook/manager.ts
:Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This pull request has been released as version
0.0.0-pr-23811-sha-d3c4b6e3
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-23811-sha-d3c4b6e3
norbert/add-sidebar-top-slot
d3c4b6e3
1692800954
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23811