Build: Add parallelism count check to CI #23839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
force-pushed
the
yann/add-parallelism-count-check
branch
from
6e05cb2 to
b28e54f
Compare
yannbf
force-pushed
the
yann/add-parallelism-count-check
branch
from
6a3116a to
51c9088
Compare
yannbf
force-pushed
the
yann/add-parallelism-count-check
branch
from
51c9088 to
c6be00e
Compare
|
CI for this PR will be hanging because |
8 tasks
yannbf
added
the
patch:yes
5 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
…-check Build: Add parallelism count check to CI (cherry picked from commit f495b35)
4 tasks
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Whenever we add sandboxes, we keep forgetting to update the parallelism count in circle CI config, which sucks.
I added a script that reads config.yml values and checks for that and makes CI fail early, so we never get into a situation where we merge work with incorrect parallelism again.
I also renamed the "script-unit-tests" job to "script-checks" to make it have a more generic purpose, and I know we'll end up adding more things to it as well later.
To test this out, you can run
yarn get-template --checkyourself while playing with the parallelism values in config.yml or playing with the sandboxes in sandbox-templates.ts and get feedback locally:Or see an actual CI failure by clicking here
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>