Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Exclude addon-styling from upgrade #23841

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

ShaunEvening
Copy link
Contributor

@ShaunEvening ShaunEvening commented Aug 15, 2023

Closes #23749

What I did

  • Exclude @storybook/addon-styling and @storybook/addon-styling-webpack from the upgrade

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Install @storybook/addon-styling
  3. Run npx storybook@latest upgrade
  4. No warning should throw because addon-styling doesn't match versions with core packages

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yannbf yannbf changed the title CLI: exclude addon-styling from upgrade CLI: Exclude addon-styling from upgrade Aug 15, 2023
@ShaunEvening ShaunEvening added patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Aug 15, 2023
@ShaunEvening ShaunEvening merged commit 936602d into next Aug 21, 2023
15 checks passed
@ShaunEvening ShaunEvening deleted the shaun/upgrade-exclude-styling branch August 21, 2023 13:51
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
20 tasks
storybook-bot pushed a commit that referenced this pull request Aug 21, 2023
storybook-bot pushed a commit that referenced this pull request Aug 21, 2023
storybook-bot pushed a commit that referenced this pull request Aug 21, 2023
storybook-bot pushed a commit that referenced this pull request Aug 21, 2023
storybook-bot pushed a commit that referenced this pull request Aug 22, 2023
storybook-bot pushed a commit that referenced this pull request Aug 22, 2023
storybook-bot pushed a commit that referenced this pull request Aug 23, 2023
storybook-bot pushed a commit that referenced this pull request Aug 23, 2023
storybook-bot pushed a commit that referenced this pull request Aug 23, 2023
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 23, 2023
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook Official Plugin Breaking Types & Migration info
3 participants