Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Adds conditional render write stories #23892

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

jonniebigodes
Copy link
Contributor

@jonniebigodes jonniebigodes commented Aug 18, 2023

Closes #22817

What I did

  • Conditionally render the Writing Stories / Introduction (Hooks) for:
    • React
    • Solid
  • Added the Solid section to the documentation
  • Fixed links to outdated documentation

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Aug 18, 2023
@jonniebigodes jonniebigodes self-assigned this Aug 18, 2023
@jonniebigodes jonniebigodes changed the title Docs adds conditional render write stories Docs: Adds conditional render write stories Aug 18, 2023
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update!

@jonniebigodes jonniebigodes merged commit 14cb60a into next Aug 25, 2023
15 checks passed
@jonniebigodes jonniebigodes deleted the docs_adds_conditional_render_write_stories branch August 25, 2023 14:14
@github-actions github-actions bot mentioned this pull request Aug 25, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Enable Framework-specific documentation
2 participants