Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Migrate registry util script from JS to TS #23931

Closed

Conversation

mastrzyz
Copy link
Contributor

What I did

  • Migrated the concurrency file to TS
  • Removed dead function not used anywhere
  • Eliminated code debt violation

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • compiler

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@mastrzyz mastrzyz changed the title fix: fix: remove ts-ignore in registry util script Aug 23, 2023
@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates ci:normal labels Aug 24, 2023
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the build is green, LGTM

@yannbf yannbf changed the title fix: remove ts-ignore in registry util script Build: Migrate registry util script from JS to TS Aug 28, 2023
@mastrzyz mastrzyz closed this Aug 28, 2023
@mastrzyz mastrzyz force-pushed the mastrzyz/remove_concurency_ts_issue branch from 01f18e3 to aecfa17 Compare August 28, 2023 14:31
@mastrzyz mastrzyz deleted the mastrzyz/remove_concurency_ts_issue branch August 28, 2023 14:32
@ndelangen
Copy link
Member

@mastrzyz why delete the branch?

@mastrzyz mastrzyz restored the mastrzyz/remove_concurency_ts_issue branch August 28, 2023 15:23
@mastrzyz
Copy link
Contributor Author

@mastrzyz why delete the branch?

had a nasty issue with merging with master, new PR -> #23976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants