Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit link on docs/examples #2396

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

ngyikp
Copy link
Contributor

@ngyikp ngyikp commented Nov 29, 2017

Right now, the Edit link on https://storybook.js.org/testing/structural-testing/ is pointing to an invalid link at https://github.com/storybooks/storybook/tree/master/docs/pages/testing/structural-testing/index.md
The correct link is https://github.com/storybooks/storybook/blob/master/docs/src/pages/testing/structural-testing/index.md

The examples page also have a similar problem.

What I did

Change the strings to point to the valid link.

How to test

Build the documentation and test the edit links.

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #2396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2396   +/-   ##
=======================================
  Coverage   19.92%   19.92%           
=======================================
  Files         293      293           
  Lines        6485     6485           
  Branches      763      756    -7     
=======================================
  Hits         1292     1292           
- Misses       4599     4604    +5     
+ Partials      594      589    -5
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/info/src/components/markdown/code.js 24.13% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.04% <0%> (ø) ⬆️
addons/jest/src/components/PanelTitle.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.88% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 21.36% <0%> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b157cae...b9fe44c. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Hypnosphi Hypnosphi merged commit fea626a into storybookjs:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants