Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix TOC import #24047

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Docs: Fix TOC import #24047

merged 1 commit into from
Sep 1, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 1, 2023

Closes N/A

What I did

Fix the import per modernweb-dev/web#2437 (comment)

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access docs/TOC stories

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman merged commit 2995f49 into next Sep 1, 2023
25 of 26 checks passed
@shilman shilman deleted the shilman/fix-tocbot-import branch September 1, 2023 17:14
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 4, 2023
storybook-bot pushed a commit that referenced this pull request Sep 4, 2023
Docs: Fix TOC import
(cherry picked from commit 2995f49)
@github-actions github-actions bot mentioned this pull request Sep 4, 2023
10 tasks
storybook-bot pushed a commit that referenced this pull request Sep 6, 2023
Docs: Fix TOC import
(cherry picked from commit 2995f49)
storybook-bot pushed a commit that referenced this pull request Sep 6, 2023
Docs: Fix TOC import
(cherry picked from commit 2995f49)
storybook-bot pushed a commit that referenced this pull request Sep 7, 2023
Docs: Fix TOC import
(cherry picked from commit 2995f49)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
Docs: Fix TOC import
(cherry picked from commit 2995f49)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
Docs: Fix TOC import
(cherry picked from commit 2995f49)
storybook-bot pushed a commit that referenced this pull request Sep 8, 2023
Docs: Fix TOC import
(cherry picked from commit 2995f49)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant