Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-loader: Fix property key validation #24068

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Source-loader: Fix property key validation #24068

merged 1 commit into from
Sep 5, 2023

Conversation

MrZillaGold
Copy link
Contributor

@MrZillaGold MrZillaGold commented Sep 4, 2023

What I did

Checking if the property has a key to export story-file parameters as a constant.

export const story: Meta<...> = {};

export default story;

Preview build error:

Снимок экрана 2023-09-04 в 16 13 07

This file has the same check for a similar place:

https://github.com/storybookjs/storybook/blob/main/code/lib/source-loader/src/abstract-syntax-tree/traverse-helpers.js#L54

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Manual testing is not required

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MrZillaGold thanks for your contribution! Great catch!

@shilman shilman changed the title fix(traverse-helpers): validate property key Source-loader: Fix property key validation Sep 4, 2023
@shilman shilman merged commit 3bab816 into storybookjs:next Sep 5, 2023
13 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 5, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants