Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix Angular 15 support and add zone.js v0.14.x support #24367

Merged
merged 15 commits into from
Oct 5, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Oct 4, 2023

Closes #24357

What I did

This pull request addresses a critical dependency issue that arose with upgrading the file-system-cache package to version 2.4.0 and now having a new types-ramda version published yesterday. The specific version depends on @types/ramda, which, in turn, requires Typescript version 5. Our project aims to maintain compatibility with Typescript version 4 to ensure seamless integration with Storybook and Angular 15, which is scaffolded with Typescript 4.x. However, the recent changes in @types/ramda have led to a broken setup since it now utilizes types-ramda, introducing Typescript syntax exclusive to version 5. This scenario manifested yesterday, disrupting the normal operation of our development environment.

To rectify this and restore the compatibility of our setup with Typescript 4.x, we are downgrading the file-system-cache package to version 2.3.0. This version does not have the problematic dependency version on @types/ramda and will ensure our setup remains functional and compatible with the existing toolchain, including Storybook and Angular 15.

Furthermore

  • Updated yarn.lock and pinned some packages to exact versions
  • the Angular 15 sandbox is readded to the CI
  • the debugWebpack CLI option was added to the Angular builder
  • tightened the supported zone.js version range

Checklist for Contributors

Testing

Manual testing

Manual testing is not required, since it is covered by CI

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Oct 4, 2023
@valentinpalkovic valentinpalkovic mentioned this pull request Oct 4, 2023
5 tasks
@valentinpalkovic valentinpalkovic changed the title bug: Ensure Angular 15 compatibility Angular: Ensure Angular 15 compatibility Oct 4, 2023
@socket-security
Copy link

socket-security bot commented Oct 4, 2023

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
svelte-check 3.5.2...3.4.6 None +2/-2 12.9 MB svelte-language-tools-deploy

🚮 Removed packages: @storybook/client-logger@7.4.1, @sveltejs/vite-plugin-svelte@2.4.5, @types/tmp@0.2.3, file-system-cache@2.4.4, next@13.5.4, zone.js@0.13.1

@valentinpalkovic valentinpalkovic changed the title Angular: Ensure Angular 15 compatibility Angular: Ensure Angular 15 compatibility + Add zone.js v0.14.x support Oct 4, 2023
@valentinpalkovic valentinpalkovic changed the title Angular: Ensure Angular 15 compatibility + Add zone.js v0.14.x support Angular: fix Angular 15 and add zone.js v0.14.x support Oct 4, 2023
@yannbf yannbf changed the title Angular: fix Angular 15 and add zone.js v0.14.x support Angular: Fix Angular 15 support and add zone.js v0.14.x support Oct 4, 2023
@yannbf yannbf added ci:merged Run the CI jobs that normally run when merged. and removed ci:normal labels Oct 4, 2023
@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:merged Run the CI jobs that normally run when merged. ci:daily Run the CI jobs that normally run in the daily job. labels Oct 5, 2023
@valentinpalkovic valentinpalkovic merged commit 7d8a2c6 into next Oct 5, 2023
27 of 40 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-angular-sandbox branch October 5, 2023 09:08
@yannbf yannbf mentioned this pull request Oct 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook compilation fails because of types-ramda dependency
4 participants