-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSF: Automatically extract componentPath #24396
Conversation
As much as I love this PR, I guess given its limitations we might need to park it. 😢 |
Hi friends! 👋 Just noticed this PR and it's super exciting for us at StackBlitz, so I'm happy to chime in with our use case: We have an addon that allows opening the source of a story in a browser IDE with a git support. This enables Storybook instance maintainers to easily adjust things when they're off or need other updates: they can just click a link on a given story and get the source files and Storybook running live in a dev server in a browser separate tab. They make a change and commit. For this, when setting up the addon, one has to
With programmatic access to |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a57e45c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, but needs to update API docs as well.
@sulco Sorry for the delay -- coming soon to 8.2! ❤️ |
Oh wow, I've almost missed it 😅 This is awesome, thanks everyone!! 😍 |
Closes N/A
What I did
rawComponentPath
for indexcomponentPath
to indexAutomatically addparameters.componentPath
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Create a sandbox in this branch and then view its
/index.json
. Verify thatrawComponentPath
is set correctly in the index for various cases (e.g. relative path, absolute path, alias, package import):Example: https://630511d655df72125520f051-hyyhhtkyeo.chromatic.com/index.json
🦋 Canary release
This pull request has been released as version
0.0.0-pr-24396-sha-51edf4aa
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-24396-sha-51edf4aa
shilman/auto-component-path
51edf4aa
1697008617
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24396