Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix pnp support when cache dir is outside working dir #24572

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Oct 25, 2023

Closes #23497

What I did

Fixed an issue where static dirs couldn't be resolved in yarn pnp mode, if yarn's cache folder was outside the working dir

Checklist for Contributors

Testing

Manual testing

  1. Clone https://github.com/rawfg/storybook-pnp-issue on a Windows machine
  2. Open .yarnrc.yml and configure the caching folder outside of the current working directory. Ideally on another volume.
  3. Run Storybook. Storybook should start without issues

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Oct 25, 2023
@valentinpalkovic valentinpalkovic changed the title Fix pnp support when cache dir is outside working dir StaticDir: Fix pnp support when cache dir is outside working dir Oct 25, 2023
@valentinpalkovic valentinpalkovic changed the title StaticDir: Fix pnp support when cache dir is outside working dir Core: Fix pnp support when cache dir is outside working dir Oct 25, 2023
@valentinpalkovic valentinpalkovic merged commit 047a9a6 into next Oct 26, 2023
61 of 72 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-pnp-support-for-ext-cache-dir branch October 26, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook + Yarn PnP Windows drive issue
2 participants