Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove storyStoreV7 feature flag #24658

Merged
merged 44 commits into from
Jan 9, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 1, 2023

Relates to #25117

What I did

Step 2 of #24655

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Fails
🚫 PR is marked with "BREAKING CHANGE" label.
🚫

Please choose only one of these labels: ["BREAKING CHANGE","maintenance"]

Generated by 🚫 dangerJS against 8bd86ad

@yannbf
Copy link
Member

yannbf commented Jan 3, 2024

Please add migration notes that cover all breaking changes, especially when it comes to APIs which could break addons 🙏

These two issues might give a bit of light, but there is definitely much more to cover:
#25367
#25365

@ndelangen
Copy link
Member Author

@yannbf this PR does not remove the actual runtime of storyStoreV7 flag inside the preview code.

This PR removes:

  • the ability to set the flag
  • the code in the builders to support it

tom's PR that's a follow up for this one, will refactor the preview code.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Left a few minor comments!

The following issue was introduced in 7.4: quantizor/markdown-to-jsx#535
Downgrading to 7.3.2 will fix it
@valentinpalkovic valentinpalkovic added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Jan 8, 2024
@valentinpalkovic valentinpalkovic merged commit 8404f74 into next Jan 9, 2024
99 of 100 checks passed
@valentinpalkovic valentinpalkovic deleted the norbert/remove-storystorev7 branch January 9, 2024 12:15
tmeasday added a commit that referenced this pull request Feb 28, 2024
Looks like these got lost in a merge conflict with #24658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE ci:daily Run the CI jobs that normally run in the daily job. core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants