Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: Update jscodeshift to v0.15.1 #24882

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Dependency: Update jscodeshift to v0.15.1 #24882

merged 3 commits into from
Nov 17, 2023

Conversation

epreston
Copy link
Contributor

Updating jscodeshift, used by @storybook/cli to 0.15.1 to remove warnings on deployment.

Currently, the storybook/cli has the following dependency tree:

└─┬ storybook@7.5.3
  └─┬ @storybook/cli@7.5.3
    └─┬ jscodeshift@0.14.0
      └── @babel/plugin-proposal-class-properties@7.18.6

This produces the following warnings when installing storybook and it's dependencies.

npm WARN deprecated @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
npm WARN deprecated @babel/plugin-proposal-nullish-coalescing-operator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
npm WARN deprecated @babel/plugin-proposal-optional-chaining@7.21.0: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.   

What I did

  • update jscodeshift@0.15.1
  • I wasn't sure how "lock files" are managed by this project so I left that alone.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Deploy Storybook
  2. Run the storybook project updater to ensure code migrations function correctly.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
jscodeshift 0.15.1 None +0 264 kB daniel15

@valentinpalkovic valentinpalkovic merged commit 0d9a95c into storybookjs:next Nov 17, 2023
4 of 5 checks passed
@valentinpalkovic valentinpalkovic changed the title chore: remove warnings by updating to jscodeshift@0.15.1 Dependency: Update jscodeshift to v0.15.1 Nov 17, 2023
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
36 tasks
@epreston epreston deleted the patch-1 branch November 17, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants