-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compatibility with @babel/core v7 #2494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2494 +/- ##
=======================================
Coverage 16.87% 16.87%
=======================================
Files 307 307
Lines 7792 7792
Branches 780 780
=======================================
Hits 1315 1315
- Misses 5863 5871 +8
+ Partials 614 606 -8
Continue to review full report at Codecov.
|
Please do the same for storyshots addon https://github.com/storybooks/storybook/blob/3b03c7e1b9b39f34b4fe3ac337bedd614eb73a75/addons/storyshots/package.json |
typo do same for storyshots addon
@Hypnosphi done ✅ |
Thanks, will test |
Issue:
When using babel v7-beta, this happens:
What I did
I moved
babel-core
to peerDependencies. This waybabel-core
is not installed again into@storybook/react/node_modules/
How to test
Use it with @babel7 dependencies and babel-bridge