-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SvelteKit: Fix HMR not working #25031
Merged
JReinhold
merged 1 commit into
next
from
25029-bug-sveltekit-hot-reload-not-working-after-upgrading-to-storybook-76
Nov 29, 2023
Merged
SvelteKit: Fix HMR not working #25031
JReinhold
merged 1 commit into
next
from
25029-bug-sveltekit-hot-reload-not-working-after-upgrading-to-storybook-76
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
approved these changes
Nov 29, 2023
JReinhold
deleted the
25029-bug-sveltekit-hot-reload-not-working-after-upgrading-to-storybook-76
branch
November 29, 2023 10:06
storybook-bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76 SvelteKit: Fix HMR not working (cherry picked from commit 7ffc515)
This was referenced Nov 29, 2023
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76 SvelteKit: Fix HMR not working (cherry picked from commit 7ffc515)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76 SvelteKit: Fix HMR not working (cherry picked from commit 7ffc515)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76 SvelteKit: Fix HMR not working (cherry picked from commit 7ffc515)
storybook-bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76 SvelteKit: Fix HMR not working (cherry picked from commit 7ffc515)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Nov 29, 2023
44 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:normal
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
sveltekit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25029
What I did
Changed the Vite plugin that adds aliases mocks from returning a full, merged config to only returning a partial config. I don't know why this fixes HMR. 🤷
Also removed
enforce: 'post'
on it, not because it contributed to the issue, but I didn't see any noticeable change with or without it, it didn't seem to do anything.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25031-sha-f8489ef6
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25031-sha-f8489ef6
25029-bug-sveltekit-hot-reload-not-working-after-upgrading-to-storybook-76
f8489ef6
1701251008
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25031