Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit: Fix HMR not working #25031

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Nov 29, 2023

Closes #25029

What I did

Changed the Vite plugin that adds aliases mocks from returning a full, merged config to only returning a partial config. I don't know why this fixes HMR. 🤷
Also removed enforce: 'post' on it, not because it contributed to the issue, but I didn't see any noticeable change with or without it, it didn't seem to do anything.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-25031-sha-f8489ef6. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-25031-sha-f8489ef6
Triggered by @JReinhold
Repository storybookjs/storybook
Branch 25029-bug-sveltekit-hot-reload-not-working-after-upgrading-to-storybook-76
Commit f8489ef6
Datetime Wed Nov 29 09:43:28 UTC 2023 (1701251008)
Workflow run 7030704506

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25031

@JReinhold JReinhold self-assigned this Nov 29, 2023
@JReinhold JReinhold added bug sveltekit ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch labels Nov 29, 2023
@JReinhold JReinhold merged commit 7ffc515 into next Nov 29, 2023
70 of 74 checks passed
@JReinhold JReinhold deleted the 25029-bug-sveltekit-hot-reload-not-working-after-upgrading-to-storybook-76 branch November 29, 2023 10:06
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76

SvelteKit: Fix HMR not working
(cherry picked from commit 7ffc515)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76

SvelteKit: Fix HMR not working
(cherry picked from commit 7ffc515)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76

SvelteKit: Fix HMR not working
(cherry picked from commit 7ffc515)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76

SvelteKit: Fix HMR not working
(cherry picked from commit 7ffc515)
storybook-bot pushed a commit that referenced this pull request Nov 29, 2023
…load-not-working-after-upgrading-to-storybook-76

SvelteKit: Fix HMR not working
(cherry picked from commit 7ffc515)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 29, 2023
@github-actions github-actions bot mentioned this pull request Dec 7, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch sveltekit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SvelteKit Hot reload not working after upgrading to storybook 7.6
2 participants