Addon Remark-GFM: Upgrade remark-gfm #25301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/7293160971 |
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
yannbf
force-pushed
the
yann/upgrade-remark-gfm
branch
2 times, most recently
from
5224f11
to
5e89e91
Compare
shilman
approved these changes
Dec 28, 2023
yannbf
force-pushed
the
yann/upgrade-remark-gfm
branch
from
5e89e91
to
ad66a20
Compare
yannbf
commented
Dec 29, 2023
valentinpalkovic
approved these changes
Jan 3, 2024
|
Are we keeping this addon around for 8.0 actually? |
Yes, I spoke to @shilman and the decision was to have this stick a little longer so users can have a smoother migration process. If you feel like we should reconsider, please let us know! |
|
I want to support a direct 6.5 to 8.0 upgrade since roughly half our users are still on 6.5. We can drop this in 9.0. |
yannbf
force-pushed
the
yann/upgrade-remark-gfm
branch
from
c1df8f0
to
c08716a
Compare
yannbf
force-pushed
the
yann/upgrade-remark-gfm
branch
from
c810703
to
1f79ab2
Compare
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #25182
What I did
Upgraded remark-gfm from v3 to v4, which contains a few possible breaking changes, but mostly Node 16 being the minimum version
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>