-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-Docs: Upgrade to MDX3 #25303
Merged
Merged
Addon-Docs: Upgrade to MDX3 #25303
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
22808ba
upgrade docs-mdx to use mdx3
yannbf b111368
upgrade mdx-js/react in addon-docs
yannbf ecea7dd
bring mdx-csf compiler into addon docs
yannbf 9cdef8d
update docs-mdx canary
yannbf 9a4a44a
fix mdx loader and cleanup
yannbf aa6a421
update mdx compiler tests
yannbf 4209c50
fix mdx support on sandboxes
yannbf bd5ea14
ugprade docs-mdx
yannbf e627dbc
remove deprecation checks
yannbf 1716cae
add migration notes
yannbf a80c3d5
ignore ts error
yannbf 1be44eb
remove .stories.mdx stories and fix tests
yannbf a7bd3e5
upgrade docs-mdx
yannbf cfc86fc
remove unnecessary comment
yannbf 3dcf056
rename .stories.mdx to .mdx
yannbf 2071832
remove jsxOptions from addon-docs
yannbf ca6f060
refactor mdx-loader logic
yannbf 7c4e18e
upgrade docs-mdx
yannbf 85af265
Update MIGRATION.md
yannbf 2c6afe2
Update MIGRATION.md
yannbf 97ae404
remove legacy mdx 1 feature documentation
yannbf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any substantial reason why not the latest version of @babel/core is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just the version defined in mdx2-csf. The caret should resolve to the latest version though. I can upgrade as well.