-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add configurable tags-based exclusion from sidebar/autodocs #25328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
force-pushed
the
shilman/autodocs-filter
branch
from
January 2, 2024 04:49
e894c0b
to
bf8289f
Compare
shilman
force-pushed
the
shilman/autodocs-filter
branch
from
January 2, 2024 05:13
bf8289f
to
685b825
Compare
shilman
changed the title
Docs: Add autodocs filter function parameter
UI: Add configurable tags-based exclusion from sidebar/autodocs
Jan 6, 2024
shilman
requested review from
JReinhold,
cdedreuille,
kasperpeulen,
ndelangen,
yannbf,
tmeasday and
IanVS
as code owners
January 10, 2024 04:15
8 tasks
Indexer: Add metaTags and make autodocs inherit them
Self-merging @tmeasday @JReinhold |
27 tasks
This was referenced Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
docs.stories.filter
to control which stories show up in the stories blockmain.ts
field calledtags
to configure tag behaviortags['tag-name'].excludeFromSidebar
to hide stories from the sidebartags['tag-name'].excludeFromDocsStories
to hide stories from the Stories block'dev-only': { excludeFromDocsStories: true }
'docs-only': { excludeFromSidebar: true }
'test-only': { excludeFromSidebar: true, excludeFromDocsStories: true }
The default
docs.stories.filter
is backwards compatible with the previous behavior which filters out stories with a truthydocs.disable
parameter.Checklist for Contributors
Testing
Added e2e tests in the telescoping PR #25537
The changes in this PR are covered in the following automated tests:
Manual testing
tags: ['dev-only']
to a story & observe it disappear from autodocstags: ['docs-only']
to a story & observe it disappear from the sidebartags: ['test-only']
to a story & observe it disappear from both the sidebar and autodocsfoo
to the main.ts configuration & restart storybook:Documentation
👉 Needs docs
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25328-sha-5fe992e9
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25328-sha-5fe992e9
shilman/autodocs-filter
5fe992e9
1704191544
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25328