Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add migration notes about storiesOf removal #25436

Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 3, 2024

Relates to #25117

What I did

Added migration notes about the removal of storiesOf-API.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen self-assigned this Jan 3, 2024
@ndelangen ndelangen added documentation core ci:docs Run the CI jobs for documentation checks only. api: stories labels Jan 3, 2024
MIGRATION.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen, thanks for putting together this pull request mentioning the storiesOf API removal to the migration guide. Appreciate it. I'll check the rest of the documentation for some other places where we're referencing them and adjust accordingly.

MIGRATION.md Outdated Show resolved Hide resolved
@valentinpalkovic valentinpalkovic merged commit c6ffc8f into next Jan 9, 2024
17 of 18 checks passed
@valentinpalkovic valentinpalkovic deleted the norbert/add-migration-note-about-removal-storiesof branch January 9, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: stories ci:docs Run the CI jobs for documentation checks only. core documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants