Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoTitle: Fix case-insensitive trailing duplicate #25452

Merged

Conversation

ksugawara61
Copy link
Contributor

@ksugawara61 ksugawara61 commented Jan 4, 2024

Closes #25451

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Create case-insenstive directory and story file in sandbox env ex) src/stories/button/Button.stories.ts
  2. Remove title parameter from Button.stories.ts
  3. Access local storybook server and you can confirm stories/Button

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@tmeasday tmeasday requested a review from shilman January 5, 2024 09:39
@shilman shilman changed the title fix: to support sanitize for case-insensitive trailing duplicate AutoTitle: Fix case-insensitive trailing duplicate Jan 8, 2024
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ksugawara61 !! Fix looks great and thank you for adding a test too 🙌

@shilman shilman merged commit 898557a into storybookjs:next Jan 8, 2024
51 of 53 checks passed
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 8, 2024
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Automatic title sanitization does not support case-insensitive trailing duplicate.
2 participants