-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack: Update StorybookConfig import in core-webpack types.ts #25740
Merged
valentinpalkovic
merged 3 commits into
next
from
valentin/fix-storybook-config-typing-for-webpack-projects
Jan 31, 2024
Merged
Webpack: Update StorybookConfig import in core-webpack types.ts #25740
valentinpalkovic
merged 3 commits into
next
from
valentin/fix-storybook-config-typing-for-webpack-projects
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
requested review from
kasperpeulen and
JReinhold
as code owners
January 25, 2024 09:51
valentinpalkovic
added
ci:daily
Run the CI jobs that normally run in the daily job.
and removed
ci:normal
labels
Jan 25, 2024
yannbf
reviewed
Jan 26, 2024
yannbf
reviewed
Jan 26, 2024
valentinpalkovic
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Jan 29, 2024
yannbf
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
valentinpalkovic
deleted the
valentin/fix-storybook-config-typing-for-webpack-projects
branch
January 31, 2024 14:05
This was referenced Jan 31, 2024
Merged
8 tasks
shilman
added a commit
that referenced
this pull request
Feb 6, 2024
…fig-typing-for-webpack-projects Webpack: Update StorybookConfig import in core-webpack types.ts (cherry picked from commit a91240a)
Closed
8 tasks
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
ci:daily
Run the CI jobs that normally run in the daily job.
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25739
Closes #22472
What I did
Updated StorybookConfig import in core-webpack types.ts to use the proper StorybookConfig type and fix type bugs, which were introduced by this change.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
.storybook/main.ts
to add theenv
propertyenv
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>