-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Improve how the addon panel work on mobile #25787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few code suggestions, nothing big.
However it poses a problem with large preview sizes, caused by long preview content or just using a large viewport setting. The addon panel won't shrink/cover the preview at all, so if there's no room for preview+panel in the current viewport, the panel just won't show. I think we need to do something about that, I'm not sure what though. Perhaps give the addon panel a min height, and let the preview shrink (scrollable) in that case?
Try this with the "Large mobile" viewport in a small browser window to see how the panel behaves.
What I did
Closes #24424
On the new mobile layout we used to show the addon panel above the canvas. In cases where you use
layout: centred
the addon panel would hide quite a large part of the UI. To fix that, I replicated the desktop behaviour and made the addon panel appear below the canvas.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25787-sha-ce3d85aa
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-25787-sha-ce3d85aa sandbox
or in an existing project withnpx storybook@0.0.0-pr-25787-sha-ce3d85aa upgrade
.More information
0.0.0-pr-25787-sha-ce3d85aa
charles-fix-mobile-addon-panel
ce3d85aa
1706528287
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25787