-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix custom tabs not showing in the manager #25792
UI: Fix custom tabs not showing in the manager #25792
Conversation
…s on the container component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, only a few minor comments. Also needs a migration note mentioning the URL for tabs have now changed, and that tabId
is now passed into match
and how to use it.
Will you do a Documentation Request too?
@JReinhold I added the migration notes, and submitted a documentation update request 👍 Thank you for the reminder! |
…-navigating-to-addon-tab
…-to-addon-tab' of https://github.com/storybookjs/storybook into jeppe/25322-bug-main-section-disappears-when-navigating-to-addon-tab
…-navigating-to-addon-tab
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@playwright/test@1.36.0, npm/playwright-core@1.36.0, npm/playwright@1.36.0 |
…-to-addon-tab' of https://github.com/storybookjs/storybook into jeppe/25322-bug-main-section-disappears-when-navigating-to-addon-tab
…-navigating-to-addon-tab
…-navigating-to-addon-tab
MIGRATION.md
Outdated
@@ -386,6 +387,46 @@ | |||
|
|||
## From version 7.x to 8.0.0 | |||
|
|||
### Tab addons are now routed to a query parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration note should describe the URL structure before the change and after. The current content should be moved down to "Addon author changes" since it's really not end user facing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we can merge this PR as is and fix it in a follow-on PR, since time is tight
…-to-addon-tab' of https://github.com/storybookjs/storybook into jeppe/25322-bug-main-section-disappears-when-navigating-to-addon-tab
…-navigating-to-addon-tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you split up that migration note after merge :D
Closes #25322
Closes: #25758
What I did
&tab={tabId}
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
.storybook/manager.ts
tab=...
when the "Canvas" tab is activeDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>