Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove more .stories.mdx handling #25973

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Feb 9, 2024

What I did

Remove more references to .stories.mdx support. This is mostly tests, but there are also a few places where we explicitly handled the stories-mdx tag that has now been removed.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold self-assigned this Feb 9, 2024
@JReinhold JReinhold added maintenance User-facing maintenance tasks core ci:normal labels Feb 9, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shilman does this change look safe to you? this is the only significant thing in this PR, the rest are just tests and telemetry

@JReinhold JReinhold marked this pull request as ready for review February 9, 2024 21:21
@@ -66,7 +66,6 @@ export const transformSetStoriesStoryDataToPreparedStoryIndex = (
if (docsOnly) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will docsOnly exist anymore after we get rid of .stories.mdx support @tmeasday ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but this code is back compat for composition, is it not @shilman ?

@JReinhold
Copy link
Contributor Author

@shilman could you see if you could get this over the finish line, especially with the composition question above, which is not my expertise?

@JReinhold JReinhold assigned shilman and unassigned JReinhold May 15, 2024
Copy link

nx-cloud bot commented Jun 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c388109. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit 1af1f3c into next Jun 10, 2024
59 of 61 checks passed
@shilman shilman deleted the jeppe/remove-more-stories-mdx branch June 10, 2024 09:17
@github-actions github-actions bot mentioned this pull request Jun 10, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants