CLI: Fix logic to add ^
packages in upgrade
#26049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25811
What I did
I changed the logic that determins to add or not add a
^
to the version range to upgrade to.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This is super hard to test, I could use some help finding ways to test this proper.
I think it will require publishing to verdaccio multiple times, withg multiple versions and possible multiple dist tags. Not something we really have scripts for to do.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26049-sha-b8adcad0
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26049-sha-b8adcad0 sandbox
or in an existing project withnpx storybook@0.0.0-pr-26049-sha-b8adcad0 upgrade
.More information
0.0.0-pr-26049-sha-b8adcad0
norbert/fix-caret-in-upgrade
b8adcad0
1708426541
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26049