Addon-controls: Dont show "setup controls" if control is disabled or a function #26120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdedreuille
approved these changes
Feb 20, 2024
yannbf
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Why was control.disable removed?
Also, why would users not want to see that their components have args which are functions? If that looks ugly, you could just change the content to something else like a static "function" text or something, but not really remove it right? Else this can be confusing for users, especially people who build component libraries and want to document their components properly.
shilman
reviewed
Feb 20, 2024
| @@ -65,7 +65,7 @@ export const ArgControl: FC<ArgControlProps> = ({ row, arg, updateArgs, isHovere | |||
| const onBlur = useCallback(() => setFocused(false), []); | |||
| const onFocus = useCallback(() => setFocused(true), []); | |||
|
|
|||
| if (!control || control.disable) | |||
| if (!control && row.type?.name !== 'function') | |||
kasperpeulen
force-pushed
the
kasper/fn-control-ui
branch
from
59456bf
to
90050a4
Compare
kasperpeulen
force-pushed
the
kasper/fn-control-ui
branch
from
90050a4
to
563d20b
Compare
yannbf
approved these changes
Feb 20, 2024
kasperpeulen
force-pushed
the
kasper/fn-control-ui
branch
from
8df8159
to
f9b9958
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24475
What I did
Dont show "setup controls" if control is disabled or a function
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>