-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix composition of storybooks on same origin #26304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it possible to have refs share the same origin as each other and as the main storybook. This is useful if you have static-storybooks in static directories
…b.com/storybookjs/storybook into norbert/composition-loading-state-fix
ndelangen
commented
Mar 5, 2024
ndelangen
commented
Mar 5, 2024
ndelangen
commented
Mar 5, 2024
ndelangen
commented
Mar 5, 2024
ndelangen
changed the title
Core: Improve the refs detection
Core: Improve refs detection
Mar 5, 2024
shilman
changed the title
Core: Improve refs detection
Core: Fix composition of storybooks on same origin
Mar 5, 2024
shilman
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!! 💪
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25957
What I did
This makes it possible to have refs share the same origin as each other and as well as the main storybook.
This is useful if you have static-storybooks in static directories
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
What I did was:
yarn build-storybook
in the sandboxstatic-storybook
directory tofoo
and copied it into thestatic
directory of the sandboxmain.ts
file:yarn storybook
(dev-mode).iframe
was being shown on both routesDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26304-sha-8cbb06d9
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26304-sha-8cbb06d9 sandbox
or in an existing project withnpx storybook@0.0.0-pr-26304-sha-8cbb06d9 upgrade
.More information
0.0.0-pr-26304-sha-8cbb06d9
norbert/composition-loading-state-fix
8cbb06d9
1709650484
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26304