Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: Return component from composeStory #26317

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Mar 5, 2024

Rework of #26198 targeting next
Closes #26192

What I did

  • Changed composeStory in Vue to return a component instead of returning the story function. See migration notes in this PR for details.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26317-sha-fcd8bf2c. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26317-sha-fcd8bf2c sandbox or in an existing project with npx storybook@0.0.0-pr-26317-sha-fcd8bf2c upgrade.

More information
Published version 0.0.0-pr-26317-sha-fcd8bf2c
Triggered by @JReinhold
Repository storybookjs/storybook
Branch jeppe/compose-vue-api-changes
Commit fcd8bf2c
Datetime Tue Mar 5 11:22:58 UTC 2024 (1709637778)
Workflow run 8155438373

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26317

@JReinhold JReinhold self-assigned this Mar 5, 2024
@JReinhold JReinhold requested a review from yannbf March 5, 2024 11:22
@JReinhold JReinhold added BREAKING CHANGE and removed maintenance User-facing maintenance tasks labels Mar 5, 2024
@JReinhold JReinhold marked this pull request as ready for review March 5, 2024 11:33
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against ba64b33

MIGRATION.md Outdated Show resolved Hide resolved
@yannbf yannbf merged commit 6c71508 into next Mar 5, 2024
55 of 56 checks passed
@yannbf yannbf deleted the jeppe/compose-vue-api-changes branch March 5, 2024 17:17
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portable stories - Create experimental API for Playwright CT in Vue3
2 participants