Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Automigrations copy edits #26342

Merged
merged 3 commits into from
Mar 25, 2024
Merged

CLI: Automigrations copy edits #26342

merged 3 commits into from
Mar 25, 2024

Conversation

joevaugh4n
Copy link
Contributor

Hey, I updated the copy for the CLI prompt so that it’s a bit clearer on what we do now in SB8, rather than just saying ‘hey we don’t do this any more’.

Please feel free to edit (or reject, if you think it’s unnecessary), but I hope to make it a bit clearer about what we’re changing, which – in turn – makes it easier for folks to upgrade!

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Changed copy in the remove-argtypes-regex script
@kasperpeulen kasperpeulen added maintenance User-facing maintenance tasks ci:normal labels Mar 6, 2024
@jonniebigodes jonniebigodes changed the title Edited the copy in the remove-argtypes-regex.ts CLI: Automigrations copy edits Mar 25, 2024
@jonniebigodes jonniebigodes self-assigned this Mar 25, 2024
Copy link

nx-cloud bot commented Mar 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3aaa3bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes
Copy link
Contributor

@joevaugh4n thanks for taking the time to put together this pull request and helping us improve our messaging in the CLI. Appreciate it 🙏 ! I've checked and same as Valentin the copy edits are good on my end as well. Going to merge this once the checklist clears

@jonniebigodes jonniebigodes merged commit 83de652 into next Mar 25, 2024
51 of 61 checks passed
@jonniebigodes jonniebigodes deleted the cli-copy-edit branch March 25, 2024 16:02
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants