-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automigrations: Fix missing support for mts vite config #26441
Automigrations: Fix missing support for mts vite config #26441
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 807aaa4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @drik98 for your contribution!
@valentinpalkovic Will this be merged? |
@drik98 Thank you for the heads up! Merging in progress... |
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
…vite-config Automigrations: Fix missing support for mts vite config (cherry picked from commit 5e2c5e0)
What I did
When migrating to storybook 8.0.0 using
pnpm dlx storybook@latest upgrade
one of the migration checks saidwhich is wrong because my project does have a vite config file (
vite.config.mts
) just with a different ending then expected from storybook. Storybook already supports both.mjs
and.ts
so I just added.mts
as well as it is already working even though the message says it does not.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Already worked for me locally anyway.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>