Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix panel layout resizing do not apply when done too fast #26460

Merged
merged 7 commits into from
May 7, 2024
Merged

UI: Fix panel layout resizing do not apply when done too fast #26460

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c9dc4e0
Fix #25759: Panel resizing is not applied when done too fast
jorge-ji Mar 12, 2024
445e0cd
Merge branch 'next' into my-first-storybook-contribution
ndelangen Mar 26, 2024
eae5d3a
Merge branch 'next' into my-first-storybook-contribution
JReinhold Apr 22, 2024
875af9d
Merge branch 'next' into my-first-storybook-contribution
JReinhold Apr 24, 2024
18df4de
fix: remove state from dependency array
jorge-ji Apr 27, 2024
3ed89f3
Merge branch 'next' into my-first-storybook-contribution
ndelangen Apr 29, 2024
f4b07b5
Merge branch 'next' into my-first-storybook-contribution
ndelangen May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion code/ui/manager/src/components/layout/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const useLayoutSyncingState = ({
useLayoutEffect(() => {
if (
internalDraggingSizeState.isDragging || // wait with syncing managerLayoutState until user is done dragging
layoutStateIsEqual(prevManagerLayoutStateRef.current, internalDraggingSizeState) // don't sync managerLayoutState if it doesn't differ from internalDraggingSizeState
layoutStateIsEqual(managerLayoutState, internalDraggingSizeState) // don't sync managerLayoutState if it doesn't differ from internalDraggingSizeStatee)
) {
return;
}
Expand All @@ -95,6 +95,7 @@ const useLayoutSyncingState = ({
...nextState,
};
setManagerLayoutState(nextState);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [internalDraggingSizeState, setManagerLayoutState]);

const isPagesShown =
Expand Down