Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming: Update emotion dependencies #26623

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 22, 2024

Closes #25480

What I did

Updated the version in package.json, then ran yarn up -R '@emotion/*'

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Mar 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4cf0272. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen changed the title chore: update emotion dependencies Theming: Update emotion dependencies Mar 25, 2024
@SimenB
Copy link
Contributor Author

SimenB commented Mar 25, 2024

Would it be possible to backport this to v7, btw?

@ndelangen ndelangen merged commit 772ce6e into storybookjs:next Mar 25, 2024
51 checks passed
@ndelangen
Copy link
Member

ndelangen commented Mar 25, 2024

@shilman WDYT about back-porting this to 7.x?

@github-actions github-actions bot mentioned this pull request Mar 25, 2024
22 tasks
@SimenB SimenB deleted the update-emotion-deps branch March 26, 2024 08:33
@bashmish
Copy link
Contributor

@shilman WDYT about back-porting this to 7.x?

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants