Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Support module mocking with conditional subpath imports in package.json #26688

Merged
merged 109 commits into from
May 1, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 29, 2024

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26688-sha-553a642b. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26688-sha-553a642b sandbox or in an existing project with npx storybook@0.0.0-pr-26688-sha-553a642b upgrade.

More information
Published version 0.0.0-pr-26688-sha-553a642b
Triggered by @yannbf
Repository storybookjs/storybook
Branch kasper/module-mocking
Commit 553a642b
Datetime Mon Apr 15 07:21:36 UTC 2024 (1713165696)
Workflow run 8685051027

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26688

Copy link

nx-cloud bot commented Mar 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c2818a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen marked this pull request as ready for review April 30, 2024 14:35
@JReinhold JReinhold changed the title Test: Support module mocking with conditional package.json imports Test: Support module mocking with conditional subpath imports in package.json May 1, 2024
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through all the code again, just the important tests and stories.

Looks great 💪

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the Vite conditions change I made a comment of

@kasperpeulen kasperpeulen merged commit 0bf9744 into next May 1, 2024
107 checks passed
@kasperpeulen kasperpeulen deleted the kasper/module-mocking branch May 1, 2024 13:40
@github-actions github-actions bot mentioned this pull request May 3, 2024
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: actions ci:daily Run the CI jobs that normally run in the daily job. core feature request nextjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants