-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Support module mocking with conditional subpath imports in package.json
#26688
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0c2818a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
d43fe28
to
3ff3e13
Compare
…s/storybook into jeppe/teardown-on-forceremount
…ook into jeppe/teardown-loading-reload
…s/storybook into jeppe/teardown-on-forceremount
…js/storybook into jeppe/rerender-queue
…odule-mocking # Conflicts: # code/renderers/react/src/__test__/portable-stories.test.tsx
Action: Add new actions to the bottom of the panel and auto scroll
Next.js: Add `/cache.mock` entrypoint
Next: Use `<<package>>::<<import>>` naming convention for mock names
package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go through all the code again, just the important tests and stories.
Looks great 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the Vite conditions change I made a comment of
What I did
<<package>>::<<import>>
naming convention for mock names #26853Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26688-sha-553a642b
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-26688-sha-553a642b sandbox
or in an existing project withnpx storybook@0.0.0-pr-26688-sha-553a642b upgrade
.More information
0.0.0-pr-26688-sha-553a642b
kasper/module-mocking
553a642b
1713165696
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26688