Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add duration and onClick support to Notification API/UI #26696

Merged
merged 13 commits into from
Apr 3, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Mar 30, 2024

What I did

Updates the Notification API and UI:

  • Adds duration property to auto-close notification after a set time. Shows a "countdown" bar on the notification to indicate when it will close.
  • Adds onClick property to trigger a function on click, passing an onDismiss callback so the notification may be dismissed on click. UI is like the link variant, with an added focus ring for better accessibility.
  • Added "slide in" animation for when notification appears, to make it draw some attention and be less jarring.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26696-sha-63254fdd. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26696-sha-63254fdd sandbox or in an existing project with npx storybook@0.0.0-pr-26696-sha-63254fdd upgrade.

More information
Published version 0.0.0-pr-26696-sha-63254fdd
Triggered by @ghengeveld
Repository storybookjs/storybook
Branch improve-notifications
Commit 63254fdd
Datetime Wed Apr 3 14:41:32 UTC 2024 (1712155292)
Workflow run 8540689586

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26696

Copy link

nx-cloud bot commented Mar 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 63254fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ghengeveld ghengeveld changed the title Improve notifications Core: Improve notifications Mar 31, 2024
@ghengeveld ghengeveld changed the title Core: Improve notifications Core: Add duration and onClick support to Notification API and improve Notification UI Mar 31, 2024
@ghengeveld ghengeveld marked this pull request as ready for review March 31, 2024 14:03
@ghengeveld ghengeveld merged commit e0c5ff4 into next Apr 3, 2024
63 of 66 checks passed
@ghengeveld ghengeveld deleted the improve-notifications branch April 3, 2024 20:09
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
15 tasks
@shilman shilman changed the title Core: Add duration and onClick support to Notification API and improve Notification UI Core: Add duration and onClick support to Notification API/UI Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants