-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add Visual Tests addon install auto-migration when upgrading to 8.0.x #26766
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 90055cb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…n we release this in"
return dedent` | ||
New to Storybook 8: Storybook's Visual Tests addon helps you catch unintentional changes/bugs in your stories. The addon is powered by Chromatic, a cloud-based testing tool developed by Storybook's core team. | ||
|
||
Learn more: storybook.js.org/docs/writing-tests/visual-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learn more: storybook.js.org/docs/writing-tests/visual-testing | |
Learn more: ${chalk.yellow('https://storybook.js.org/docs/writing-tests/visual-testing'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something about long URLs getting chopped up and not being copy-pastable when inside boxen
. So I think we might want to keep it as short as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW the Chromatic CLI uses cyan
for links.
CLI: Add Visual Tests addon install auto-migration when upgrading to 8.0.x (cherry picked from commit c9fbb76)
CLI: Add Visual Tests addon install auto-migration when upgrading to 8.0.x (cherry picked from commit c9fbb76)
CLI: Add Visual Tests addon install auto-migration when upgrading to 8.0.x (cherry picked from commit c9fbb76)
CLI: Add Visual Tests addon install auto-migration when upgrading to 8.0.x (cherry picked from commit c9fbb76)
Closes #26665
What I did
@chromatic-com/storybook
addon for visual regression testing.check
method of the above auto-migration.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I ran this manually on my machine:
'@chromatic-dom/storybook'
entry inmain.ts
underaddons
.../../code/lib/cli/bin/index.js upgrade
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>