-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js: Support v14.2 useParams functionality #26874
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fb24aef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…rams Nextjs: Support next 14.2 useParams functionality (cherry picked from commit 316779b)
Hi @yannbf! Any chance this could be back-ported to Storybook 7 as well since it is also an issue there? |
Hey @RickyRoller we could try, but now that Storybook 8 is out (actually we just released 8.1), we are likely only patching security fixes back to Storybook 7. Could you try upgrading your project to Storybook 8? There are incredible new features in @storybook/nextjs that would make your life easier! |
Closes #26850
What I did
This PR implements the new structure included in Nextjs 14.2 regarding
next/navigation
useParams. It's non-breaking for next 13.5 (the lowest version we support) so we actually don't need to do aliasing. I tested thoroughly with sandboxes and portable stories in both Next 14 and 13.I also moved some stories from the Nextjs JS sandbox to Nextjs TS sandbox instead, and updated the portable stories one.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>