Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Upgrade deps of @storybook/test #27862

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Test: Upgrade deps of @storybook/test #27862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f01ba
Upgrade deps of @storybook/test
kasperpeulen Jun 5, 2024
40b1799
Update deps
kasperpeulen Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...@vitest-expect-npm-1.3.1-973071a540.patch → ...@vitest-expect-npm-1.6.0-0e382f8212.patch
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 8 additions & 7 deletions code/lib/test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@
"exports": {
".": {
"types": "./dist/index.d.ts",
"node": "./dist/index.js",
"import": "./dist/index.mjs",
"require": "./dist/index.js"
"require": "./dist/index.js",
"node": "./dist/index.js",
"default": "./dist/index.mjs"
},
"./package.json": "./package.json"
},
Expand All @@ -47,11 +48,11 @@
"@storybook/core-events": "workspace:*",
"@storybook/instrumenter": "workspace:*",
"@storybook/preview-api": "workspace:*",
"@testing-library/dom": "^9.3.4",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/user-event": "^14.5.2",
"@vitest/expect": "1.3.1",
"@vitest/spy": "^1.3.1",
"@testing-library/dom": "10.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this theoretically a breaking change?

BREAKING CHANGES
Minimum supported Node.js version is 18.0
New version of aria-query changes various roles. Check out the changed tests in testing-library/dom-testing-library@2c57055 to get an overview about what changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:
#27229 (comment)

"@testing-library/jest-dom": "6.4.5",
"@testing-library/user-event": "14.5.2",
"@vitest/expect": "1.6.0",
"@vitest/spy": "1.6.0",
"util": "^0.12.4"
},
"devDependencies": {
Expand Down
3 changes: 1 addition & 2 deletions code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,8 @@
"resolutions": {
"@playwright/test": "1.36.0",
"@storybook/theming": "workspace:*",
"@testing-library/jest-dom/aria-query": "5.1.3",
"@types/node": "^18.0.0",
"@vitest/expect": "patch:@vitest/expect@npm%3A1.3.1#~/.yarn/patches/@vitest-expect-npm-1.3.1-973071a540.patch",
"@vitest/expect": "patch:@vitest/expect@npm%3A1.6.0#~/.yarn/patches/@vitest-expect-npm-1.6.0-0e382f8212.patch",
"esbuild": "^0.20.1",
"playwright": "1.36.0",
"playwright-core": "1.36.0",
Expand Down
Loading