Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Introduce preserveSymlink builder option #28145

Merged

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

This PR introduces a new builder option, "preserveSymlinks", which is passed further to the underlying Angular Webpack builder.

Second, I try to finally fix the creation of Angular sandboxes in linked mode. There is one remaining caveat in linked mode, though: The code has to be built for production. For that, I have introduced a new --prod flag for the yarn task CLI so that sandboxes can be created in link mode, but the underlying packages are build for production.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

  1. Run an Angular-specific sandbox with the --prod flag, e.g. yarn task --prod --task sandbox --start-from auto --template angular-cli/default-ts
  2. Open Storybook in your browser
  3. Make sure Storybook doesn't crash

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic force-pushed the valentin/angular-introduce-preserve-symlink-option branch from b8faac9 to 096c612 Compare June 7, 2024 12:54
Copy link

nx-cloud bot commented Jun 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 096c612. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review June 8, 2024 09:57
@valentinpalkovic valentinpalkovic merged commit 9b8b946 into next Jun 10, 2024
59 of 61 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/angular-introduce-preserve-symlink-option branch June 10, 2024 09:27
@github-actions github-actions bot mentioned this pull request Jun 10, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants