Dependency: Remove node-fetch

[yk-kd]

Closes #27156

What I did

Updated node-fetch package from v2 to v3.
node-fetch v3 removes the whatwg-url dependency, so no more issue warnings.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit beff8b5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build --parallel=3

---

Sent with 💌 from NxCloud.

[valentinpalkovic]

Hi @yk-kd,

thank you for your contribution!

v3 of node-fetch is ESM only and since our build output is CJS and ESM, the import will fail in CJS environments. You have to use dynamic imports to import node-fetch, because dynamic imports are the only way importing ESM in CJS. The dynamic import has to happen in a asynchronous function though, because we don’t support top-level awaits so far.

So you have to change the "normal" import to an async import (const nodeFetch = await import('node-fetch')) and additionally move the import into the function, where it is used. Make sure that the parent function is marked as asynchronous. If it isn’t the case yet, please make sure to transform it to an async function and to await it everywhere, where it is called.

[yk-kd]

@valentinpalkovic

thank you for your review.

I fixed to use dynamic import in commonjs.
Nodejs 18 can use fetch without node-fetch.
Have you considered removing the node-fetch dependency?

[valentinpalkovic]

Good call! Let’s try it!

[yk-kd]

@valentinpalkovic
Node-fetch under code seems to have been removed in #27039
I've changed it so that it is removed from scripts as well, just in case.
Should I close the PR now that the original purpose has been achieved?

[valentinpalkovic]

Hi @yk-kd. No, don’t close it. The core package consolidation moved nearly all Storybook packages to code/core. I guess node/fetch is a dependency there.

[yk-kd]

Hi @valentinpalkovic,

There is no node-fetch dependency in package.json when grepping under code.
There is one in yarn.lock, but it is a dependency of danger or octokit.

[valentinpalkovic]

Interesting! @ndelangen have you removed node-fetch as part of CPC?

[greptile-apps]

PR Summary

• Removed node-fetch import from /docs/_snippets/loader-story.md
• Removed node-fetch import from /docs/_snippets/storybook-preview-global-loader.md
• Removed node-fetch dependency from /scripts/event-log-checker.ts
• Removed node-fetch and its types from /scripts/package.json
• Removed node-fetch import from /scripts/release/is-version-published.ts

_{10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}