Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC: Cleanup the ui dir #28346

Merged
merged 10 commits into from
Jun 25, 2024
Merged

CPC: Cleanup the ui dir #28346

merged 10 commits into from
Jun 25, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 25, 2024

What I did

  • I moved code/ui/blocks to code/lib/blocks
  • I moved code/ui/.storybook to code/.storybook
  • I updated any paths to reflect those above changes
  • I removed any unused code in linting config etc.

I did this, because we have no more plans to have code/ui occupied by any other code other than blocks.

Also .storybook makes more sense in the top level code directory anyway.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen self-assigned this Jun 25, 2024
@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Jun 25, 2024
Copy link

nx-cloud bot commented Jun 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c9e78f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 52e8e1f into norbert/cpc Jun 25, 2024
49 of 52 checks passed
@ndelangen ndelangen deleted the norbert/cpc-cleanup branch June 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants