Next: Set default targets for next babel config #28443
Conversation
kasperpeulen
added
ci:daily
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
kasperpeulen
added
ci:daily
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5b81e5b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore This alias is set in the sandbox. Using ts-ignore instead of ts-expect-error to avoid build errors in the sandbox. | ||
|
|
||
| import { foo } from '#utils'; |
There was a problem hiding this comment.
They were moved by norbert to the core directory, when he tried to consolidate the test package.
However, in the end the test package was not consolidated, so they were duplicated.
What I did
Set default targets for next babel config
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
/code/frameworks/nextjs/src/babel/preset.ts/code/frameworks/nextjs/src/babel/preset.tsshowStoryDuringRendercallback in/code/core/src/preview-api/modules/preview-web/PreviewWithSelection.tsxNoStoryMountedErrorclass in/code/core/src/preview-errors.ts/code/core/src/preview-api/modules/preview-web/render/StoryRender.test.ts