Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable stories: Remove unused types #28548

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Jul 11, 2024

Closes #28527

What I did

Remove unused type

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff %
createTime 23.3s 24s 686ms 2.9%
generateTime 20.4s 24.1s 3.6s 🔺15.2%
initTime 22.3s 23.6s 1.2s 🔺5.4%
createSize 0 B 0 B 0 B -
generateSize 76.5 MB 76.5 MB 216 B 0%
initSize 205 MB 205 MB 128 B 0%
diffSize 128 MB 128 MB -88 B 0%
buildTime 12.8s 15.4s 2.6s 🔺16.9%
buildSize 7.59 MB 7.59 MB 0 B 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 0%
buildSbCommonSize 195 kB 195 kB 0 B 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 0%
buildSbPreviewSize 349 kB 349 kB 0 B 0%
buildStaticSize 0 B 0 B 0 B -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0%
testBuildTime 0ms 0ms 0ms -
testBuildSize 0 B 0 B 0 B -
testBuildSbAddonsSize 0 B 0 B 0 B -
testBuildSbCommonSize 0 B 0 B 0 B -
testBuildSbManagerSize 0 B 0 B 0 B -
testBuildSbPreviewSize 0 B 0 B 0 B -
testBuildStaticSize 0 B 0 B 0 B -
testBuildPrebuildSize 0 B 0 B 0 B -
testBuildPreviewSize 0 B 0 B 0 B -
devPreviewResponsive 11s 9.4s -1s -594ms 🔰-16.9%
devManagerResponsive 6.9s 6.4s -538ms 🔰-8.4%
devManagerHeaderVisible 1.1s 958ms -166ms 🔰-17.3%
devManagerIndexVisible 1.1s 971ms -197ms 🔰-20.3%
devStoryVisibleUncached 1.6s 1s -552ms 🔰-52.5%
devStoryVisible 1.1s 1s -143ms 🔰-13.8%
devAutodocsVisible 961ms 960ms -1ms -0.1%
devMDXVisible 909ms 799ms -110ms 🔰-13.8%
buildManagerHeaderVisible 1s 893ms -107ms 🔰-12%
buildManagerIndexVisible 1s 945ms -57ms 🔰-6%
buildStoryVisible 1s 958ms -108ms 🔰-11.3%
buildAutodocsVisible 994ms 893ms -101ms 🔰-11.3%
buildMDXVisible 882ms 765ms -117ms 🔰-15.3%

@kasperpeulen kasperpeulen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jul 11, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Removed unused properties playPromise and renderingEnded from UnwrappedImportStoryRef type in code/core/src/preview-api/modules/store/csf/portable-stories.ts
  • Simplified UnwrappedImportStoryRef to just ComposedStoryFn

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a52726f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title React: Remove unused type Portable stories: Remove unused types Jul 12, 2024
@shilman shilman merged commit 5075c13 into next Jul 12, 2024
56 of 61 checks passed
@shilman shilman deleted the kasper/remove-unused-type branch July 12, 2024 09:30
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 12, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 13, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
storybook-bot pushed a commit that referenced this pull request Jul 15, 2024
Portable stories: Remove unused types

(cherry picked from commit 5075c13)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch portable stories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot find name 'PromiseWithResolvers'
2 participants