-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App-angular: upgrade ts-loader to 3.3.1 #2855
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2855 +/- ##
==========================================
- Coverage 37.48% 35.82% -1.66%
==========================================
Files 434 428 -6
Lines 9389 9423 +34
Branches 915 987 +72
==========================================
- Hits 3519 3376 -143
- Misses 5313 5389 +76
- Partials 557 658 +101
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop configFileName support (replaced by configFile) BREAKING CHANGE
might be safer to save this for the next major or minor instead of patch? otherwise, seems okay.
We don't pass any options to it: https://github.com/storybooks/storybook/blob/master/app/angular/src/server/config/webpack.config.js#L73 |
Ok, but the only field is |
d5f81ae
to
cb3dd00
Compare
Changelog
Angular example seems to work just OK
This change is