-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix header for MountMustBeDestructuredError message #28590
Core: Fix header for MountMustBeDestructuredError message #28590
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6899755. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Added header to
MountMustBeDestructuredError
message in/code/core/src/preview-errors.ts
- Ensured error message displays correctly in the preview by meeting
showErrorDisplay
requirements
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Fix: Add header for MountMustBeDestructuredError message (cherry picked from commit 0b54024)
Closes #28514
What I did
The preview displaying
MountMustBeDestructuredError
doesn't have a title on top becauseshowErrorDisplay
takes the first line of the error message asheader
.storybook/code/core/src/preview-api/modules/preview-web/WebView.ts
Lines 138 to 151 in 955f307
This PR adds a header to the
MountMustBeDestructuredError
message.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>