Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add conditional logging for manager and preview start #28603

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Jul 15, 2024

What I did

In quiet mode, "Starting preview/manager" are no longer printed.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff %
createTime 9.1s 16.9s 7.7s 🔺45.8%
generateTime 29s 19.8s -9s -221ms 🔰-46.5%
initTime 27.6s 20.3s -7s -257ms 🔰-35.6%
createSize 0 B 0 B 0 B -
generateSize 76.5 MB 76.5 MB 0 B 0%
initSize 198 MB 198 MB 44 B 0%
diffSize 121 MB 121 MB 44 B 0%
buildTime 13.1s 14.8s 1.6s 🔺11.3%
buildSize 7.59 MB 7.59 MB 0 B 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B 0%
buildSbCommonSize 195 kB 195 kB 0 B 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 0%
buildSbPreviewSize 349 kB 349 kB 0 B 0%
buildStaticSize 0 B 0 B 0 B -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0%
testBuildTime 0ms 0ms 0ms -
testBuildSize 0 B 0 B 0 B -
testBuildSbAddonsSize 0 B 0 B 0 B -
testBuildSbCommonSize 0 B 0 B 0 B -
testBuildSbManagerSize 0 B 0 B 0 B -
testBuildSbPreviewSize 0 B 0 B 0 B -
testBuildStaticSize 0 B 0 B 0 B -
testBuildPrebuildSize 0 B 0 B 0 B -
testBuildPreviewSize 0 B 0 B 0 B -
devPreviewResponsive 10.1s 9.2s -878ms 🔰-9.4%
devManagerResponsive 6.1s 6s -163ms -2.7%
devManagerHeaderVisible 794ms 926ms 132ms 🔺14.3%
devManagerIndexVisible 806ms 961ms 155ms 🔺16.1%
devStoryVisibleUncached 1.5s 1.6s 146ms 🔺8.6%
devStoryVisible 845ms 986ms 141ms 🔺14.3%
devAutodocsVisible 742ms 789ms 47ms 🔺6%
devMDXVisible 732ms 832ms 100ms 🔺12%
buildManagerHeaderVisible 753ms 807ms 54ms 🔺6.7%
buildManagerIndexVisible 754ms 811ms 57ms 🔺7%
buildStoryVisible 810ms 874ms 64ms 🔺7.3%
buildAutodocsVisible 716ms 722ms 6ms 0.8%
buildMDXVisible 689ms 771ms 82ms 🔺10.6%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added conditional logging for preview start in /code/core/src/core-server/dev-server.ts
  • Suppressed '=> Starting preview..' log message when options.quiet is true

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8e31fb2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added maintenance User-facing maintenance tasks cli labels Jul 15, 2024
@shilman shilman changed the title feat: add conditional logging for manager and preview start CLI: Add conditional logging for manager and preview start Jul 15, 2024
@ndelangen ndelangen merged commit 6c895fe into storybookjs:next Jul 16, 2024
54 of 58 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
12 tasks
@tobiasdiez tobiasdiez deleted the quiet branch July 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants