Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Send benchmarking base list to bot #28613

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 15, 2024

What I did

I tweaked the data being send to the benchmark-reporter-bot.

We now send the last 20 base builds, instead of just the last one.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B NaN -
generateSize 76.5 MB 76.5 MB 455 B 1.73 0%
initSize 198 MB 198 MB 455 B -1.33 0%
diffSize 121 MB 121 MB 0 B -1.34 0%
buildSize 7.59 MB 7.59 MB 0 B 0.5 0%
buildSbAddonsSize 1.63 MB 1.63 MB 0 B NaN 0%
buildSbCommonSize 195 kB 195 kB 0 B NaN 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B NaN 0%
buildSbPreviewSize 349 kB 349 kB 0 B NaN 0%
buildStaticSize 0 B 0 B 0 B NaN -
buildPrebuildSize 4.47 MB 4.47 MB 0 B NaN 0%
buildPreviewSize 3.12 MB 3.12 MB 0 B 0.5 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 7s 21s 14s -0.85 66.8%
generateTime 21.7s 21.3s -443ms -0.42 -2.1%
initTime 23.3s 22.4s -866ms 0.13 -3.9%
buildTime 15.6s 13.3s -2s -282ms 1.43 🔰-17%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.5s 7.9s 400ms -1.18 5%
devManagerResponsive 5.2s 5.2s -10ms -1.01 -0.2%
devManagerHeaderVisible 753ms 790ms 37ms -0.97 4.7%
devManagerIndexVisible 787ms 795ms 8ms -0.83 1%
devStoryVisibleUncached 1s 1.3s 283ms -0.93 21.1%
devStoryVisible 803ms 843ms 40ms -1.02 4.7%
devAutodocsVisible 716ms 856ms 140ms -0.28 16.4%
devMDXVisible 667ms 678ms 11ms -1.23 1.6%
buildManagerHeaderVisible 725ms 846ms 121ms -0.83 14.3%
buildManagerIndexVisible 730ms 849ms 119ms -0.82 14%
buildStoryVisible 772ms 907ms 135ms -0.87 14.9%
buildAutodocsVisible 655ms 783ms 128ms -0.65 16.3%
buildMDXVisible 638ms 768ms 130ms -0.61 16.9%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Modified query to fetch last 20 benchmark results in /scripts/upload-bench.ts
  • Updated structure of 'base' data sent to benchmarking bot

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Jul 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f702ad7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Jul 15, 2024
@ndelangen ndelangen self-assigned this Jul 15, 2024
@ndelangen ndelangen requested a review from shilman July 15, 2024 18:10
@ndelangen ndelangen changed the title Send benchmarking base list to bot Build: Send benchmarking base list to bot Jul 15, 2024
@ndelangen ndelangen merged commit ecae394 into next Jul 15, 2024
64 of 70 checks passed
@ndelangen ndelangen deleted the norbert/send-multiple-base-data-to-benchmarking-bot branch July 15, 2024 18:33
@github-actions github-actions bot mentioned this pull request Jul 15, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant